teams: smoother survey submissions formatting (fixes #9285) #9308
Conversation
Mutugiii
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
paulbert
left a comment
paulbert
left a comment
There was a problem hiding this comment.
Sorry I got caught up a little today. Haven't been able to test yet, but wanted to add these comments on what I was able to read through.
| ...submission, | ||
| teamInfo: submission.team ? { name: submission.team.name, type: submission.team.type } : null | ||
| })); | ||
| return of<[any[], number, string[]]>([submissionsWithTeamInfo, time, questionTexts]); |
There was a problem hiding this comment.
A few things that were here before that could be improved:
- This doesn't need to be a switchMap, it can just be a map since it's returning a static value not another observable. Then you can remove the of and just return the array on this line.
- I think the indentation was a little off here. Bumping the switchMap, or map, down to a new line and then indenting the function would make this clearer.
| }) | ||
| ).pipe(map((updatedSubmissions: any[]): [ any[], number, string[] ] => [ updatedSubmissions, time, questionTexts ]) | ||
| ); | ||
| return of<[any[], number, string[]]>([submissionsWithPlanetName, time, questionTexts]); |
There was a problem hiding this comment.
Same, since we're no longer pulling in team info here via another observable we can just use a map instead of switchMap and return the array.
|
I tried to test, but honestly I'm a bit confused about the expected user experience here. As a manager I created a survey and sent it to a team. Then I logged in as a member of that team, but there wasn't a request to take the survey. I saw that the survey is available now in the team's list of surveys as a survey to record responses from the community. I was curious how this differed from the team created surveys, and saw that when a team creates a survey there isn't a submissions document. That's more what I would expect on the database side for this kind of team survey. A submission document should be specific record of a survey or exam submission. I might be missing something, but I'm having trouble seeing why this workflow is using the submissions database at all? |
dogi
changed the title
Fixes #9285 #9067
Improve submissions document format:
Add source to PDF/CSV exports